Fix pub_sub example that no longer compiles in 0.13 #989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
reviewed
Mar 2, 2020
| @@ -7,5 +7,5 @@ edition = "2018" | |||
| log = "0.4" | |||
| web_logger = "0.1" | |||
| serde = { version = "1.0", features = ["derive"] } | |||
| yew = { path = "../.." } | |||
| yew = { path = "../..", features = ["std_web"] } | |||
There was a problem hiding this comment.
Actually stdweb isn't needed as an explicit dependency. My preferred fix would be to:
- Remove
stdwebdependency - Follow the other
stdweb/web-sysagnostic examples and setup theCargo.tomllike this:
yew = { path = "../.." }
[features]
std_web = ["yew/std_web"]
web_sys = ["yew/web_sys"]There was a problem hiding this comment.
I cannot find how to start an example that uses web_sys. Can you link to some instructions? :)
EDIT: I just saw yewstack/docs#34 that is related to this.
There was a problem hiding this comment.
@totorigolo you can also check out this build script (although it's kinda broken atm) https://github.com/yewstack/yew/blob/master/examples/build_all.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The pub_sub example is no longer compiling with yew 0.13, because it is missing the
"std_web"feature. This PR fixes this. I also took the opportunity to fix some typos and unneeded code.