Feat: Add new observable button in Observables list view #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomchop
requested changes
Jan 22, 2024
|
Also, in the screenshot you shared, some observalbe names seem to be misaligned?
Given that we have a long list of observables, would it be better to use a |
Fixed in 1010eff
|
tomchop
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
New Observablebutton in observable view like it's already implemented under Indicator and Entities views.When clicking on the button, all observables types list is rendered and when clicking on one observable type it will render a new modal window containing fields to provide. Once saved, user is redirected to the newly created observable.