Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use set_empty_values function #1741

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

uri-99
Copy link
Contributor

@uri-99 uri-99 commented Jan 15, 2025

Use set_empty_values function

Description

set_empty_values function is to centralize where we set empty values on an explorer page failure. This avoids a failure we had in prod where on a failure, not every value was set to its appropriate empty value, so phoenix crashed.

This was already implemented here #1676

Type of change

Please delete options that are not relevant.

  • New feature
  • Bug fix
  • Optimization
  • Refactor

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link
Collaborator

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JuArce JuArce added this pull request to the merge queue Jan 15, 2025
Merged via the queue into staging with commit 1e5be3b Jan 15, 2025
1 check passed
@JuArce JuArce deleted the fix-apply-empty-values-on-explorer branch January 15, 2025 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants