Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix(explorer): fetch latest version from env instead of github #1738

Merged
merged 4 commits into from
Jan 14, 2025

Conversation

klaus993
Copy link
Collaborator

@klaus993 klaus993 commented Jan 14, 2025

When GitHub is down this function breaks the site

This has been applied in-place in mainnet.

Testing

Run the explorer locally and verify that the version is shown according to the value you set.

When GitHub is down this function breaks the site

This has been applied in-place in mainnet
@JuArce JuArce changed the title Explorer hotfix hotfix(explorer): fetch latest version from env instead of github Jan 14, 2025
explorer/.env.dev Outdated Show resolved Hide resolved
explorer/.env.example Outdated Show resolved Hide resolved
Copy link
Collaborator

@Oppen Oppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM other than what @JuArce pointed out.

@MarcosNicolau MarcosNicolau requested a review from JuArce January 14, 2025 16:10
@JuArce JuArce merged commit 9a4b37b into testnet Jan 14, 2025
1 check passed
@JuArce JuArce deleted the explorer-hotfix branch January 14, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants