Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(alerts): Add slack alerts for task submission sender #1734

Open
wants to merge 4 commits into
base: testnet
Choose a base branch
from

Conversation

PatStiles
Copy link
Contributor

Add slack alerts for task submission sender

Description

Detects error messages logged returned from when the task sender sends proofs and sends them as separate slack messages to the slack alerts channel.

To Test:

  • start a local devnet
  • Specify a PRIVATE_KEY and SENDER_ADDRESS in ./alerts/.env that does not have a batcher balance to trigger InsufficientBalance Errors
  • execute the alert script via ./alerts/sender_with_alert.sh ./alerts/.env
    You should observe that the error messages printed in the slack alerts channel as follows:
Error submitting proof to devnet:  Batcher responded with insufficient balance

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

Copy link
Collaborator

@MarcosNicolau MarcosNicolau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, testing slack notifications and I'll approve it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants