Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(sdk): Add msg to batcher errors telling a users their funds have not been spent #1725

Merged
merged 3 commits into from
Jan 14, 2025
Merged

feat(sdk): Add msg to batcher errors telling a users their funds have not been spent #1725

merged 3 commits into from
Jan 14, 2025

Conversation

PatStiles
Copy link
Contributor

Add msg to batcher errors telling a users there funds have not been spent

Description

Addresses the third item of #1568

Type of change

Please delete options that are not relevant.

  • New feature

Checklist

  • “Hotfix” to testnet, everything else to staging
  • Linked to Github Issue
  • This change depends on code or research by an external entity
    • Acknowledgements were updated to give credit
  • Unit tests added
  • This change requires new documentation.
    • Documentation has been added/updated.
  • This change is an Optimization
    • Benchmarks added/run
  • Has a known issue
  • If your PR changes the Operator compatibility (Ex: Upgrade prover versions)
    • This PR adds compatibility for operator for both versions and do not change batcher/docs/examples
    • This PR updates batcher and docs/examples to the newer version. This requires the operator are already updated to be compatible

@uri-99 uri-99 changed the title feat(sdk): Add msg to batcher errors telling a users there funds have not been spent feat(sdk): Add msg to batcher errors telling a users their funds have not been spent Jan 9, 2025
@JuArce JuArce added this pull request to the merge queue Jan 14, 2025
Merged via the queue into staging with commit 4e1dc6d Jan 14, 2025
3 checks passed
@JuArce JuArce deleted the feat/add_msg_to_batcher_errors_telling_a_users_there_funds_have_not_been_spent branch January 14, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avilagaston9 avilagaston9 avilagaston9 approved these changes

@JuArce JuArce JuArce approved these changes

@JulianVentura JulianVentura JulianVentura approved these changes

@uri-99 uri-99 uri-99 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@PatStiles @uri-99 @JulianVentura @JuArce @avilagaston9