Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

[dev] Fix some flow issues #543

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from
Open

[dev] Fix some flow issues #543

wants to merge 5 commits into from

Conversation

stephanebachelier
Copy link
Collaborator

  • it remove the need to specify an empty post: {} in the flow
  • if you only want to modify a step js it will left css as default.

@stephanebachelier stephanebachelier changed the title Fix some flow issues [dev] Fix some flow issues Apr 14, 2015
sindresorhus
sindresorhus reviewed Apr 14, 2015
View reviewed changes
lib/flow.js
@@ -33,6 +33,12 @@ Flow.prototype.setSteps = function (steps) {
this._steps = steps;
};

Flow.prototype.mergeSteps = function (steps) {
// better to use _.defaults than _.merge which merge steps arrays which
// is not waht is wanted here.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grammar

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry! a non native english speaker should not try to write something intelligent at night :)

@stephanebachelier
Copy link
Collaborator Author

@sindresorhus you're back on the project? Changes made.
1/3 test failing on appveyor due to a timeout issue but Travis ok.

@arthurvr arthurvr mentioned this pull request Jun 30, 2015
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stephanebachelier @sindresorhus