fix: is_categorical_dtype is deprecated and will be removed in a futu…

…re version. Use isinstance(dtype, pd.CategoricalDtype)
ydataai · Oct 31, 2024 · 62884d7 · 62884d7
1 parent 4c99b30
commit 62884d7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/ydata_profiling/model/typeset.py b/src/ydata_profiling/model/typeset.py
@@ -122,7 +122,7 @@ def get_relations() -> Sequence[TypeRelation]:
         @series_handle_nulls
         def contains_op(series: pd.Series, state: dict) -> bool:
             return (
-                not pdt.is_categorical_dtype(series)
+                not isinstance(series.dtype, pd.CategoricalDtype)
                 and pdt.is_string_dtype(series)
                 and series_is_string(series, state)
             )
@@ -205,9 +205,9 @@ def get_relations() -> Sequence[TypeRelation]:
         @series_not_empty
         @series_handle_nulls
         def contains_op(series: pd.Series, state: dict) -> bool:
-            is_valid_dtype = pdt.is_categorical_dtype(series) and not pdt.is_bool_dtype(
-                series
-            )
+            is_valid_dtype = isinstance(
+                series.dtype, pd.CategoricalDtype
+            ) and not pdt.is_bool_dtype(series)
             if is_valid_dtype:
                 return True
             return False

diff --git a/src/ydata_profiling/model/typeset_relations.py b/src/ydata_profiling/model/typeset_relations.py
@@ -31,7 +31,7 @@ def string_is_bool(series: pd.Series, state: dict, k: Dict[str, bool]) -> bool:
     def tester(s: pd.Series, state: dict) -> bool:
         return s.str.lower().isin(k.keys()).all()
 
-    if pdt.is_categorical_dtype(series):
+    if isinstance(series.dtype, pd.CategoricalDtype):
         return False
 
     return tester(series, state)