Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make building regex module optional #1764

Merged
merged 1 commit into from
Oct 11, 2024

Conversation

bstaletic
Copy link
Collaborator

@bstaletic bstaletic commented Oct 7, 2024

Two things:

  1. Make regex optional with --no-regex/--regex
  2. Move BuildRegexModule() to the end.

Both done as a way to allow ycmd to work even if regex does not compile on some system.


This change is Reviewable

Copy link

codecov bot commented Oct 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.88%. Comparing base (e6a0baa) to head (2344ca4).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1764   +/-   ##
=======================================
  Coverage   95.88%   95.88%           
=======================================
  Files          84       84           
  Lines        8465     8465           
  Branches      163      163           
=======================================
  Hits         8117     8117           
  Misses        298      298           
  Partials       50       50           

@bstaletic bstaletic force-pushed the regex-optional branch 2 times, most recently from 815c2c7 to 2344ca4 Compare October 10, 2024 19:04
Copy link
Member

@puremourning puremourning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: nice, thanks!

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: 1 of 2 LGTMs obtained (waiting on @bstaletic)

@bstaletic bstaletic added the Ship It! Manual override to merge a PR by maintainer label Oct 11, 2024
Copy link
Contributor

mergify bot commented Oct 11, 2024

Thanks for sending a PR!

@mergify mergify bot merged commit 47371eb into ycm-core:master Oct 11, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ship It! Manual override to merge a PR by maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants