Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

raiseNotification func clean code #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

raiseNotification func clean code #16

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a6d4fc7
raiseNotification func clean code
Jeon-seongbin Jul 9, 2024
08901c4
raiseNotification func clean code
Jeon-seongbin Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions pkg/cmd/whatsupstream/notify/helpers.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
You may obtain a copy of the License at

http://www.apache.org/licenses/LICENSE-2.0
http://www.apache.org/licenses/LICENSE-2.0

Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
Expand Down Expand Up @@ -127,14 +127,16 @@ By: %s
}

func raiseNotification(title, description string, silentMode bool) error {
var err error
if silentMode {
err = beeep.Notify(title, description, "")
} else {
err = beeep.Alert(title, description, "")
if err := beeep.Notify(title, description, ""); err != nil {
return fmt.Errorf("error occurred while generating a notification alert: %w", err)
}
return nil
}
if err != nil {

if err := beeep.Alert(title, description, ""); err != nil {
return fmt.Errorf("error occurred while generating a notification alert: %w", err)
}

return nil
}