Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Car Price Prediction #123

Closed
wants to merge 7 commits into from
Closed

Car Price Prediction #123

wants to merge 7 commits into from

Conversation

Sai-ganesh-0004
Copy link

@Sai-ganesh-0004 Sai-ganesh-0004 commented Oct 11, 2024

Description

Implemented the Lasso Regression model for predicting car prices. The model includes preprocessing of the dataset, feature selection, and visualization of feature importance. Additionally, the code is structured into separate modules for better readability and maintainability.

Issue Resolved

This PR resolves #90 .

Changes Made

  • Added data preprocessing functions to handle missing values and convert categorical features.
  • Implemented Lasso Regression in predict.py for car price prediction.
  • Created a function to visualize feature importance in model.py.
  • Organized the code into a modular structure with separate files for data preprocessing, model training, evaluation, and visualization.

Additional Details

This implementation improves the model's performance by optimizing feature selection through regularization.

Checklist

  • My code follows the current project structure
  • I have thoroughly reviewed and updated the requirements.txt file to include any new packages
  • The predict.py file includes a properly implemented model_details() function, or the notebook contains this function to print a detailed model report. The model will not be accepted without this function, as it is essential for generating the necessary model details.
  • I have added relevant tests (if necessary).
  • I have added comments in the code where needed.
  • This PR is submitted under Hacktoberfest.
  • This PR is submitted under GirlScript Summer of Code (GSSoC-Extd).

Screenshots of the output

Screenshot 2024-10-11 132434

Screenshot 2024-10-11 132401

Screenshot 2024-10-11 132234

Screenshot 2024-10-11 132209

@yashasvini121
Copy link
Owner

I guess you are still working on this, because your changes do not include the page for this model.

@Sai-ganesh-0004
Copy link
Author

I didnt understand what you are talking about, Can you please explain me

@yashasvini121
Copy link
Owner

Your work is not yet complete, and it’s important to follow the project structure. The goal is to create an interactive form on the website that lets users make predictions. (The form creation is mostly managed by form_handler and page_handler)

Please check the tutorial and the project structure for help.

If you have any queries, let me know.

@Sai-ganesh-0004
Copy link
Author

ok i got it

@Sai-ganesh-0004
Copy link
Author

I have updated pages.json , updated app.py, and also added car price predictor.py file . So now can you check once

Copy link
Author

@Sai-ganesh-0004 Sai-ganesh-0004 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review

Copy link
Owner

@yashasvini121 yashasvini121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the notebook and the saved model

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Car Price Prediction
2 participants