Fixes UB when buffersize is zero #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ol-imorozko
previously approved these changes
Aug 6, 2024
TheRandomCharacter
force-pushed
the
vtbranch
branch
from
37b727b to
2ccab19
Compare
ol-imorozko
reviewed
Aug 7, 2024
ol-imorozko
requested changes
Aug 7, 2024
TheRandomCharacter
force-pushed
the
vtbranch
branch
from
738a730 to
3c88eec
Compare
ol-imorozko
previously approved these changes
Aug 8, 2024
memcpy behavior is undefined if called with invalid pointers. We were passing invalid pointers with buffer length 0. It worked but was exposed when -D_GLIBCXX_ASSERTIONS was enabled Cleans up stream.h serialization * Adds specializations for CStyle arrays to stream_in_t, stream_out_t. * Expands automatically serializing types from trivial types to trivially copyable. * Gets rid of memcopying trivially copiable types.
TheRandomCharacter
force-pushed
the
vtbranch
branch
from
3c88eec to
0343da0
Compare
GeorgyKirichenko
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing invalid pointer to memcpy is UB even if
bufferSizeis zero.