Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assistant sdk #178

Open
wants to merge 13 commits into
base: alpha
Choose a base branch
from
Open

Assistant sdk #178

wants to merge 13 commits into from

Conversation

GermanVor
Copy link

No description provided.

@@ -26,7 +26,6 @@
"import/prefer-default-export": "off",
"comma-dangle": ["error", "always-multiline"],
"indent": "off",
"@typescript-eslint/indent": ["error", 4],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Это правило prettier'ом хэндлится?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

6b0b997

не знаю что это за правило, случайно удалил

@@ -16,3 +16,5 @@ export * as thread from './generated/yandex/cloud/ai/assistants/v1/threads/threa
export * as threadService from './generated/yandex/cloud/ai/assistants/v1/threads/thread_service';
export * as user from './generated/yandex/cloud/ai/assistants/v1/users/user';
export * as userService from './generated/yandex/cloud/ai/assistants/v1/users/user_service';

export * as SDK from './sdk';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Че т я не очень понял, а откуда оно взялось? Я в proto не вижу каких-либо модулей sdk.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ты про то, что оно появилось в // generated file ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

package.json Outdated
"ai-assistants-v1",
"ai-dataset-v1",
"ai-files-v1",
"ai-foundation_models-v1",
"ai-foundation_models-v1/sdk",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кажется избыточным, предыдущий пункт должен включать и текущий тоже.

Copy link
Author

@GermanVor GermanVor Dec 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Я вот не уверен, у меня локально даже так ts ругается на sdk - что оно не видит.
Мб у меня локальный линтер с ума сходит из за подмен либ.

Поэтому добавил - чтобы точно быть уверенным, что оно хоть как то в новом релизе прорастет

export * as SDK from './sdk';

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мб у меня локальный линтер с ума сходит из за подмен либ - наверное да, вроде проросло

28ca8af

@GermanVor GermanVor changed the title [WIP] Assistant sdk Assistant sdk Dec 23, 2024
@GermanVor GermanVor requested a review from DavyJohnes December 24, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants