fix: delete order (#25)

yahoo · Jan 21, 2020 · 652520b · 652520b
1 parent 31a8377
commit 652520b
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 3 deletions.
diff --git a/lib/index.js b/lib/index.js
@@ -228,12 +228,12 @@ Config.prototype = {
 
         contents = this._parseConfigContents(fullPath, contents);
 
-        // register so that _readConfigContents() will use
-        self._configContents[fullPath] = contents;
-
         // deregister old config (if any)
         self.deleteConfig(bundleName, configName, fullPath);
 
+        // register so that _readConfigContents() will use
+        self._configContents[fullPath] = contents;
+
         if (!self._configPaths[bundleName]) {
             self._configPaths[bundleName] = {};
         }

diff --git a/tests/lib/index.js b/tests/lib/index.js
@@ -149,6 +149,21 @@ describe('config', function () {
                     expect(have.color).to.equal('red');
                 });
             });
+            it('should work twice in a row', function () {
+                var config,
+                    object = {color: 'red'};
+                config = new Config();
+                config.addConfigContents('foo', 'bar', 'x.js', object);
+                config.read('foo', 'bar', {}, function(err, have) {
+                    expect(err).to.equal(null);
+                    expect(have.color).to.equal('red');
+                });
+                config.addConfigContents('foo', 'bar', 'x.js', object);
+                config.read('foo', 'bar', {}, function(err, have) {
+                    expect(err).to.equal(null);
+                    expect(have.color).to.equal('red');
+                });
+            });
         });