Merge pull request #49 from yahoo/issue39

[issue #39] Switching from is-equal-shallow to React's shallowCompare addon
yahoo · Jul 18, 2016 · ec37e74 · ec37e74
2 parents 7eb1382 + f9369b3
commit ec37e74
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/package.json b/package.json
@@ -30,7 +30,7 @@
   ],
   "dependencies": {
     "classnames": "^2.0.0",
-    "is-equal-shallow": "^0.1.0",
+    "react-addons-shallow-compare": "^0.14.2 || ^15.0.0",
     "subscribe-ui-event": "^1.0.0"
   },
   "devDependencies": {

diff --git a/src/Sticky.jsx b/src/Sticky.jsx
@@ -10,7 +10,7 @@ import React, {Component, PropTypes} from 'react';
 
 import {subscribe} from 'subscribe-ui-event';
 import classNames from 'classnames';
-import isEqual from 'is-equal-shallow';
+import shallowCompare from 'react-addons-shallow-compare';
 
 // constants
 const STATUS_ORIGINAL = 0; // The default status, locating at the original position.
@@ -357,7 +357,7 @@ class Sticky extends Component {
     }
 
     shouldComponentUpdate (nextProps, nextState) {
-        return !this.props.shouldFreeze() && (!isEqual(this.props, nextProps) || !isEqual(this.state, nextState));
+        return !this.props.shouldFreeze() && shallowCompare(this, nextProps, nextState);
     }
 
     render () {