feat: Allow close method to be used with Promises or callbacks #562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all a big thank you for this fantastic module!
I was exploring the example folder looking for the
close()
method and I observed that it might be used in a way that suggests synchronous behavior. polling_TCP.jsChecking the implementation of the
close()
method I found out that it uses the Node.JS net.Socket class and in particular thesocket.end()
method which does not guarantee that the socket is fully closed immediately after callingsocket.end()
.This pull request introduces Promise support to the close method and should not affect the existing usage.
A callback can still be passed as argument.