-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Expand error codes #545
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To be consistent with the similarly undefined error code 0.
sjlongland
force-pushed
the
feature/expand-error-codes
branch
from
February 8, 2024 06:10
16a14c1
to
0748a09
Compare
``` Error: Code did not pass lint rulesindex.js: line 38, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 39, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 40, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 41, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 42, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 43, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 44, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 45, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 46, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 47, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 48, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) index.js: line 49, col 5, Error - Expected space or tab after '/*' in comment. (spaced-comment) 12 problems at Context.<anonymous> (node_modules/mocha-eslint/index.js:38:15) at processImmediate (node:internal/timers:466:21) ``` Sorry @SamuelToh, those comments have got to go:
wow, thank you for the pull request Ref:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the Modbus exception codes are not defined, leading to
Unknown error
as the response for things like gateway timeouts and such. This defines all the common Modbus exception codes defined in the Modbus specification.