Fix readme #533
Merged
Fix readme #533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 28, 2023 18:51
yaacov
reviewed
Nov 28, 2023
worker/README.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| # DEPRECATED | |||
There was a problem hiding this comment.
can you change to someting like 'for a more complete module see modbusdb ....
depracated is not correct here, using modbusdb is another option, it has some benefits over the worker, but it is also another dependency some users will opt to avoid
|
Thank you for the pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added info about modbusdb and example. Example in the readme is a working example)