Allow to pass socket options to TCP client #519
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yaacov thank you for the lib. It's been super useful
While doing some debugging I've made some changes to the lib and decided to create a PR.
Here are the changes:
new Socket()
_client.connect()
examples
dirRe 5) I have a question for you. When the socket emits an error and socket connection is closed, does it make sense to wait for a response (which won't come as socket is closed) and then throw a
TransactionTimedOutError
?