WriteMultipleRegisters added callback and promises workflow (#478)

* WriteMultipleRegisters added callback and promises workflow * Update servertcp_handler.js fixed missing semicolon * improved workflow in _handleWriteMultipleRegisters * fixed redefinning variable cb * removed space after function
yaacov · Oct 24, 2022 · 23ea77b · 23ea77b
1 parent df17977
commit 23ea77b
Showing 1 changed file with 20 additions and 28 deletions.
diff --git a/servers/servertcp_handler.js b/servers/servertcp_handler.js
@@ -670,27 +670,22 @@ function _handleWriteMultipleRegisters(requestBuffer, vector, unitID, callback)
 
     // write registers
     let callbackInvoked = false;
-    let cbCount = 0;
-    const buildCb = function(/* i - not used at the moment */) {
-        return function(err) {
-            if (err) {
-                if (!callbackInvoked) {
-                    callbackInvoked = true;
-                    callback(err);
-                }
-
-                return;
+    const cb = function(err) {
+        if (err) {
+            if (!callbackInvoked) {
+                callbackInvoked = true;
+                callback(err);
             }
 
-            cbCount = cbCount + 1;
+            return;
+        }
 
-            if (cbCount === length && !callbackInvoked) {
-                modbusSerialDebug({ action: "FC16 response", responseBuffer: responseBuffer });
+        if (!callbackInvoked) {
+            modbusSerialDebug({ action: "FC16 response", responseBuffer: responseBuffer });
 
-                callbackInvoked = true;
-                callback(null, responseBuffer);
-            }
-        };
+            callbackInvoked = true;
+            callback(null, responseBuffer);
+        }
     };
 
     if (length === 0)
@@ -701,19 +696,17 @@ function _handleWriteMultipleRegisters(requestBuffer, vector, unitID, callback)
     if (vector.setRegisterArray) {
         value = [];
 
-        for (i = 0; i < length; i++) {
-            cb = buildCb(i);
-
-            value.push(requestBuffer.readUInt16BE(7 + i * 2));
-            _handlePromiseOrValue(value, cb);
-        }
-
         try {
+            for (i = 0; i < length; i++) {
+                value.push(requestBuffer.readUInt16BE(7 + i * 2));
+            }
+
             if (vector.setRegisterArray.length === 4) {
                 vector.setRegisterArray(address, value, unitID, cb);
             }
             else {
-                vector.setRegisterArray(address, value, unitID);
+                var promiseOrValue = vector.setRegisterArray(address, value, unitID);
+                _handlePromiseOrValue(promiseOrValue, cb);
             }
         }
         catch (err) {
@@ -723,10 +716,9 @@ function _handleWriteMultipleRegisters(requestBuffer, vector, unitID, callback)
         var value;
 
         for (var i = 0; i < length; i++) {
-            var cb = buildCb(i);
-            value = requestBuffer.readUInt16BE(7 + i * 2);
-
             try {
+                value = requestBuffer.readUInt16BE(7 + i * 2);
+
                 if (vector.setRegister.length === 4) {
                     vector.setRegister(address + i, value, unitID, cb);
                 }