This repository has been archived by the owner on Sep 23, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 36
Allow running of arbitrary commands before and after authentication #79
Open
dexterlb
wants to merge
5
commits into
xyb3rt:master
Choose a base branch
from
dexterlb:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You should add the new flags to |
Are the commands run as the user whose password is asked or as the user who launched physlock (typically root, I suppose)? In my opinion, it would be nice if those were run as the user whose password is asked. What do you think? |
jluttine
reviewed
Oct 1, 2019
@dexterlb Thanks a lot for the changes, they are very helpful to me! Now, running the following command works and the before/after commands are executed as the normal user:
|
It would be nice to have an option to execute a command after inactivity timeout. For example, go to sleep if physlock is called but no activity happens after a certain amount of time. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let the user execute any command just before and after authenticating.
This allows for things like printing a different prompt each time, showing something just after unlocking,
etc - within physlock's VT.
As a bonus, add an option to not do any authentication at all - just execute the commands while having locked the screen. My personal favourite is running sl with no way whatsoever to interrupt it :)