Hard coding the Kindle lemmas dump file URL

xxyzz · Aug 22, 2022 · 721ea95 · 721ea95
1 parent 5092b10
commit 721ea95
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -136,6 +136,7 @@ jobs:
         if: matrix.os == 'ubuntu-latest'
         uses: actions/upload-artifact@v3
         with:
+          # Don't upload the zip file directly cuz GitHub will zip it again
           name: worddumb-${{ github.sha }}
           path: |
             .

diff --git a/build_plugin.sh b/build_plugin.sh
@@ -19,9 +19,9 @@ else
 fi
 
 # Download the latest Kindle lemmas dump file
-PROFICIENCY_VERSION=`cd Proficiency && git describe && cd ..`
-PROFICIENCY_MAJOR_VERSION=`echo $PROFICIENCY_VERSION | cut -d . -f 1`
-wget -P data -nv "https://github.com/xxyzz/Proficiency/releases/download/$PROFICIENCY_VERSION/kindle_lemmas_dump_$PROFICIENCY_MAJOR_VERSION"
+# Hard coding the link cuz GitHub API has rate limit and
+# actions/checkout can't fetch submodule's tag
+wget -P data -nv "https://github.com/xxyzz/Proficiency/releases/download/v0.1.0/kindle_lemmas_dump_v0"
 
 cp Proficiency/en/dump_kindle_lemmas.py ./
 cp Proficiency/tst.py ./libs/