Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XWIKI-22746: Images do not have an aria-label in the xwiki-slash dropdown for CKEditor #3784

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
/*
* See the NOTICE file distributed with this work for additional
* information regarding copyright ownership.
*
* This is free software; you can redistribute it and/or modify it
* under the terms of the GNU Lesser General Public License as
* published by the Free Software Foundation; either version 2.1 of
* the License, or (at your option) any later version.
*
* This software is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* Lesser General Public License for more details.
*
* You should have received a copy of the GNU Lesser General Public
* License along with this software; if not, write to the Free
* Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
* 02110-1301 USA, or see the FSF site: http://www.fsf.org.
*/

/* We hide completely icons in the CKEditor autocomplete items that are not used and therefore empty.
This is especially important for assistive tech users (regular users cannot see the image if there's no source).
Note that this extra style is required because the itemTemplate feature of CKEditor autocomplete
is not powerful enough to support our specific usecase.
since 16.10.3
*/
.ckeditor-autocomplete-item-head {
& img[src=""],
& img:not([src]),
& .ckeditor-autocomplete-item-icon-wrapper > span[class=""],
& .ckeditor-autocomplete-item-icon-wrapper > span:not([class]) {
display: none;
}
}