Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter condition is not broadcasted #1638

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Filter condition is not broadcasted #1638

wants to merge 3 commits into from

Conversation

hajdugabesz
Copy link

Fixes #963

@JohanMabille
Copy link
Member

JohanMabille commented May 31, 2019 •
edited
Loading

Thanks for this PR! We are a bit busy this weekend, I'll have a look next week.

@JohanMabille
Copy link
Member

Hi,

I think this PR only fixes the case of filtering a matrix with a condition that should be broadcast along the column axis; it does not really broadcast the condition to the shape of the filtered array whatever his shape is.

It would be better to fix the filter function itself and not introduce particular case in the API.

@JohanMabille JohanMabille mentioned this pull request Dec 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter condition is not broadcasted
2 participants
@hajdugabesz @JohanMabille