Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix converting to Gregorian #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

Korota-21
Copy link

it gives wrong date so I fix it

it's gives wrong date
@khanzi05
Copy link

khanzi05 commented Aug 8, 2023

Hi @Korota-21 , Thanks for the PR, I have seen the similar issue.

For example, this code doesnot convert all the Hijri dates to Gregorian dates correct like

12-07-1408 Hijri is 29-02-1988 but this gives 29-02-1987 where there is no 29 Feb in 1987.

DO you think, this fix will work correctly ?

@Korota-21
Copy link
Author

I have tried your example, and it works fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants