Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the pipegoose/nn/parallel_mapping.py/ParallelMapping class to check module properties in accordance with #40.
This is designed to work with the bigscience/bloom-560m model. Adjusting it to other models should be a minor change, and amounts to changing what the node_target should satisfy. The check is based on node_target as it is a string that represents a submodule or layer.
We iterate over modules using .named_modules, so I have added a function to find node_target from a module so we can check their properties. I have also added a function to find the module from a node target in case the conversion is needed.