Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test and Pre-commit errors #5

Merged
merged 2 commits into from
May 30, 2024
Merged

Fix test and Pre-commit errors #5

merged 2 commits into from
May 30, 2024

Conversation

abkfenris
Copy link
Member

Bumps the minimum version to 3.9 to match Xpublish itself. Testing on 3.8 and not finding a valid version seemed to be most of the failures.

abkfenris added 2 commits May 21, 2024 20:32
Bumps the minimum version to 3.9 to match Xpublish itself. Testing on 3.8 and not finding a valid version seemed to be most of the failures.
@abkfenris abkfenris requested review from srstsavage and removed request for srstsavage May 23, 2024 14:31
@abkfenris abkfenris requested a review from kthyng May 30, 2024 15:52
@kthyng
Copy link
Collaborator

kthyng commented May 30, 2024

Looks good to me! I didn't run locally but I see it passed checks here.

Copy link
Collaborator

@kthyng kthyng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@abkfenris abkfenris merged commit d6937b6 into main May 30, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants