Issue #196: Add the 'name' to the 'reference' block for FOREIGN KEY constraints #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfhowes
commented
Jan 6, 2024
| @@ -960,8 +967,6 @@ def set_constraint( | |||
| target_dict["constraints"] = {} | |||
| if not target_dict["constraints"].get(_type): | |||
| target_dict["constraints"][_type] = [] | |||
| if "name" in constraint: | |||
There was a problem hiding this comment.
i don't know why these were here, but they were breaking my references. Removing them did not break any other tests, so i think that maybe they were unnecessary?
There was a problem hiding this comment.
possible, it is redunant code, looks like I changed some logic, but forgot to remove this
| @@ -644,7 +644,9 @@ def test_double_single_quotes(): | |||
|
|
|||
| def test_autoincrement_order(): | |||
| # test for https://github.com/xnuinside/simple-ddl-parser/issues/208 | |||
| ddl = """CREATE TABLE table (surrogatekey_SK NUMBER(38,0) NOT NULL autoincrement start 1 increment 1 ORDER COMMENT 'Record Identification Number Ordered')""" | |||
| ddl = """CREATE TABLE table ( | |||
There was a problem hiding this comment.
they changes in this file are all from the pre-commit hook.
xnuinside
approved these changes
Jan 7, 2024
|
@cfhowes thanks for the PR again ! :) |
|
@cfhowes changes released in version 0.32.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As requested in #196, added
nameto thereferencesblock of constraints. This should allow users of the parsed output to be able to associate the FOREIGN KEY with the proper column in the table.