feature #218 solve my requirement #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dmaresma hello again :) and happy new year you too! Thanks for submitting the PR. I see flake 8 issues. In repo there is the pre-commit hooks, you can run ‘pre-commit install’ and ‘pre commit run -- all-files’ to check those issues on local machine |
|
You solved it faster than I added my comment :) |
|
My Bad, I introduce regression, by not running all test before, I'm back on the workbench. |
|
@xnuinside Ta da, it's fixed all tests passed, thanks for your time. |
|
@dmaresma awesome, thank you! I will release it soon |
xnuinside
approved these changes
Jan 5, 2024
|
@dmaresma released in version 0.31.3 https://pypi.org/project/simple-ddl-parser/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi and Happy New Year !
I would like summit to you my contribution to solve the EXTERNAL TABLE and Virtual Column ddl.
Thanks again to initiate and support this project.
#218 issue solver