Skip to content

Commit

Permalink
fix issues with comments in columns
Browse files Browse the repository at this point in the history
  • Loading branch information
xnuinside committed Sep 16, 2021
1 parent 6d65efd commit f7f7c42
Show file tree
Hide file tree
Showing 13 changed files with 389 additions and 258 deletions.
3 changes: 2 additions & 1 deletion .flake8
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
[flake8]
exclude = .github,.git,__pycache__,docs/source/conf.py,old,build,dist,simple_ddl_parser/parsetab.py,simple_ddl_parser/test.py
max-complexity = 10
max-line-length = 120
max-line-length = 120
ignore = C901, W503
6 changes: 6 additions & 0 deletions CHANGELOG.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
**v0.19.5**
Fixes:

1. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.


**v0.19.4**
1. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)

Expand Down
9 changes: 7 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -342,7 +342,6 @@ You also can provide a path where you want to have a dumps with schema with argu
1. Add more support for CREATE type IS TABLE (example: CREATE OR REPLACE TYPE budget_tbl_typ IS TABLE OF NUMBER(8,2);
2. Add support (ignore correctly) ALTER TABLE ... DROP CONSTRAINT ..., ALTER TABLE ... DROP INDEX ...
3. Add support for COMMENT ON statement
4. Add support for case COMMENT column after DEFAULT word like `col1 int DEFAULT '1' COMMENT 'Integer Column'`

## non-feature todo

Expand All @@ -357,7 +356,13 @@ For one of the work projects I needed to convert SQL ddl to Python ORM models in
So I remembered about Parser in Fakeme and just extracted it & improved.

## Changelog
**v0.19.3**
**v0.19.5**
Fixes:

1. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.


**v0.19.4**
1. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)

**v0.19.2**
Expand Down
9 changes: 7 additions & 2 deletions docs/README.rst
Original file line number Diff line number Diff line change
Expand Up @@ -386,7 +386,6 @@ TODO in next Releases (if you don't see feature that you need - open the issue)
#. Add more support for CREATE type IS TABLE (example: CREATE OR REPLACE TYPE budget_tbl_typ IS TABLE OF NUMBER(8,2);
#. Add support (ignore correctly) ALTER TABLE ... DROP CONSTRAINT ..., ALTER TABLE ... DROP INDEX ...
#. Add support for COMMENT ON statement
#. Add support for case COMMENT column after DEFAULT word like ``col1 int DEFAULT '1' COMMENT 'Integer Column'``

non-feature todo
----------------
Expand All @@ -406,7 +405,13 @@ So I remembered about Parser in Fakeme and just extracted it & improved.
Changelog
---------

**v0.19.3**
**v0.19.5**
Fixes:


#. Fixed issues with COMMENT statement in column definitions. Add bunch of tests, now they expect working ok.

**v0.19.4**


#. Added support for PARTITION BY (previously was only PARTITIONED BY from HQL)
Expand Down
Loading

0 comments on commit f7f7c42

Please sign in to comment.