Improve module objectfiles handling and moduleonly package #5376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
need #5375 |
waruqi
reviewed
Jul 23, 2024
culling is already done by dependency scanner
Arthapz
force-pushed
the
fix-module-objectfiles-handling
branch
from
815638e to
df5cb9c
Compare
Closed
Arthapz
force-pushed
the
fix-module-objectfiles-handling
branch
from
94d3e2b to
14f95cb
Compare
Arthapz
changed the title
Arthapz
force-pushed
the
fix-module-objectfiles-handling
branch
2 times, most recently
from
1f9944e to
a70ab06
Compare
Arthapz
force-pushed
the
fix-module-objectfiles-handling
branch
from
a70ab06 to
4f359b2
Compare
|
#5240 will no longer be necessary as this test is included in this PR |
I will close it when this patch is merged. |
waruqi
reviewed
Jul 24, 2024
| os.iorun("xmake -r") | ||
| end | ||
| end, catch {function(errors) | ||
| errors = errors.errors |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this patch improve modules support by
- ensuring that static / dynamic libraries public module objectfiles are beeing packed in the library
- improving module culling so no std or std.compat module should be built if they are not imported
- showing a warning when modules that are not std or std.compat are culled
- raising an error when duplicated module name are detecteds