Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix vs_runtime #4997

Closed
wants to merge 1 commit into from
Closed

Conversation

star-hengxing
Copy link
Contributor

@star-hengxing star-hengxing commented Apr 21, 2024

如果不传递 b_vscrt 参数,meson 会用 MD 编译,然后 xmake 在 on_test 会使用 MT 造成链接错误。

不知道为什么 ci 会传递已经弃用的 vs_runtime 而不是 runtimes,但 xmake 确实没有正确处理向后兼容。

https://github.com/xmake-io/xmake-repo/actions/runs/8763357032/job/24064675920?pr=3829


If you don't pass the b_vscrt argument, meson will compile with MD, and then xmake will use MT at on_test causing linking errors.

I don't know why ci passes the deprecated vs_runtime instead of runtimes, but xmake really doesn't handle backwards compatibility correctly.

https://github.com/xmake-io/xmake-repo/actions/runs/8763357032/job/24064675920?pr=3829

@waruqi
Copy link
Member

waruqi commented Apr 21, 2024

加这里治标不治本,得调下为啥没兼容取到,ci 上应该已经改成 --runtimes 了

@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


Adding this is to treat the symptoms rather than the root cause. You need to adjust why it is not compatible. It should have been changed to --runtimes on ci.

@waruqi
Copy link
Member

waruqi commented Apr 21, 2024

是这个 patch 给 break 了,我刚修复了

#4927

@waruqi waruqi closed this Apr 21, 2024
@Issues-translate-bot
Copy link

Bot detected the issue body's language is not English, translate it automatically.


It was this patch that broke, I just fixed it

@star-hengxing star-hengxing deleted the meson-vs_runtime branch April 21, 2024 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants