Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
如果不传递 b_vscrt 参数,meson 会用 MD 编译,然后 xmake 在 on_test 会使用 MT 造成链接错误。
不知道为什么 ci 会传递已经弃用的 vs_runtime 而不是 runtimes,但 xmake 确实没有正确处理向后兼容。
https://github.com/xmake-io/xmake-repo/actions/runs/8763357032/job/24064675920?pr=3829
If you don't pass the b_vscrt argument, meson will compile with MD, and then xmake will use MT at on_test causing linking errors.
I don't know why ci passes the deprecated vs_runtime instead of runtimes, but xmake really doesn't handle backwards compatibility correctly.
https://github.com/xmake-io/xmake-repo/actions/runs/8763357032/job/24064675920?pr=3829