optimize wasi-sdk detect #4799
Merged
optimize wasi-sdk detect #4799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waruqi
reviewed
Mar 5, 2024
xmake/platforms/wasm/xmake.lua
Outdated
| @@ -36,11 +36,15 @@ platform("wasm") | |||
| { | |||
| {category = "Emscripten Configuration" } | |||
| , {nil, "emsdk", "kv", nil, "The emsdk directory" } | |||
| , {category = "WASI-SDK Configuration" } | |||
| , {nil, "wasi_sdk", "kv", nil, "The wasi-sdk directory" } | |||
There was a problem hiding this comment.
目前 参数已经太多了，不建议再去对每个 toolchain 添加 option，尽可能收敛。否则以后支持上百 toolchain，不得加上百个 xxxsdk 参数
There was a problem hiding this comment.
那就只支持环境变量？我是想着都支持了比较方便用户。。。
|
commit 不要用中文 |
commit do not use Chinese |
waruqi
reviewed
Mar 5, 2024
waruqi
reviewed
Mar 5, 2024
waruqi
reviewed
Mar 5, 2024
waruqi
reviewed
Mar 5, 2024
| if opt.verbose or option.get("verbose") then | ||
| cprint("checking for wasi-sdk directory ... ${color.success}%s", sdk.sdkdir) | ||
| end | ||
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4798 (comment)