Allow use of internal CA signed certificates for msmtp #1498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, msmtp checks the validity of the certificate chain of the mail server. The new option "CMS_SMTP_CHECK_TLS_CERTIFICATE" allows use of TLS certificates signed by internal Certificate Authority that do not pass the default check. If the user sets "CMS_SMTP_CHECK_TLS_CERTIFICATE" to "NO" then the line "tls_nocertcheck" will be added to /etc/msmtprc (see dagonix/ xibo-docker/config.env.template commit).
|
For this to work, I think we also need to add the environment variable to |
By default, msmtp checks the validity of the certificate chain of the mail server. The new option "CMS_SMTP_CHECK_TLS_CERTIFICATE" allows use of TLS certificates signed by internal Certificate Authority that do not pass the default check. If the user sets "CMS_SMTP_CHECK_TLS_CERTIFICATE" to "NO" then the line "tls_nocertcheck" will be added to /etc/msmtprc
|
Yes ! You're right, I added the line there. Thank you. |
alexharrington
requested changes
Dec 6, 2022
| @@ -289,6 +289,11 @@ then | |||
| /bin/sed -i "s/tls_starttls .*$/tls_starttls off/" /etc/msmtprc | |||
| fi | |||
|
|
|||
| if [ "$CMS_SMTP_CHECK_TLS_CERTIFICATE" == "NO" ] | |||
| then | |||
| /bin/sed -i "s/tls .*$/tls_nocertcheck/" /etc/msmtprc | |||
There was a problem hiding this comment.
I think this will match the line:
tls on
and replace it with tls_nocertcheck?
But I think the correct syntax would be to have both? ie
tls on
tls_nocertcheck
Perhaps it might be better to have in the template msmtprc file
# CMS_SMTP_USE_TLS
tls on
#CMS_SMTP_CHECK_TLS_CERTIFICATE
#tls_nocertcheck
and then update the sed command to remove the comment if necessary?
/bin/sed -i "s/#tls_nocertcheck.*$/tls_nocertcheck/" /etc/msmtprc
There was a problem hiding this comment.
Yes, absolutly. Both options are necessary :
tls on
tls_nocertcheck
You are right Alex.
|
I've moved this to 3.3.2 to allow more time to ensure we get it right. Issue: xibosignage/xibo#2939 |
|
Thank you Dan, Alex is right, both options are necessary. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, msmtp checks the validity of the certificate chain of the mail server. The new option "CMS_SMTP_CHECK_TLS_CERTIFICATE" allows use of TLS certificates signed by internal Certificate Authority that do not pass the default check. If the user sets "CMS_SMTP_CHECK_TLS_CERTIFICATE" to "NO" then the line "tls_nocertcheck" will be added to /etc/msmtprc (see dagonix/ xibo-docker/config.env.template commit).