-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing focus tutorials
in API
#475
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #475 +/- ##
=======================================
Coverage 91.90% 91.90%
=======================================
Files 60 60
Lines 4375 4375
=======================================
Hits 4021 4021
Misses 354 354 ☔ View full report in Codecov by Sentry. |
Thanks @thomasrobiglio! Looks great! Two quick question before you merge: (1) can we remove the top-level tutorials folder now? (2) can we get rid of the quickstart notebook? Thanks for all the work on this! |
Oops! I was looking at the wrong branch! Disregard (1). |
Yes, we can remove the quickstart tuto. If we don't have time constraints for a new release I'd like to take 2-3 more days to check for imprecisions before merging. |
Sounds great! I'll approve it and you can merge it when you think it's ready. |
Nice! I added another In Depth tuto in #456 but somehow I cannot see in main now. |
@maximelucas will do tomorrow. To see it in the API you should also put the reference in the corresponding .rst file (https://github.com/xgi-org/xgi/blob/main/docs/source/api/tutorials/in_depth.rst#in-depth-tutorials in this case). Idk if there is an automated way to have all the .ipynb files displayed but the way we are doing it now has some upsides e.g. we can choose the order in which tutos are displayed and create the different categories. |
I will open a new PR, I messed up something locally. |
No description provided.