Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP-43265: Updates config dialog. CP-42066: Rebranding tweaks. Retrieve available updates. Reflect status on icons. #3179

Merged
merged 5 commits into from
Jul 28, 2023
Merged

CP-43265: Updates config dialog. CP-42066: Rebranding tweaks. Retrieve available updates. Reflect status on icons. #3179

merged 5 commits into from
Jul 28, 2023

Conversation

kc284
Copy link
Contributor

@kc284 kc284 commented Jul 24, 2023

Each commit is self contained, please review them separately.

@kc284 kc284 self-assigned this Jul 24, 2023
@kc284 kc284 force-pushed the feature/cdn-updates branch 2 times, most recently from e77fe60 to 60f7bb4 Compare July 25, 2023 08:55
@kc284 kc284 added the ASAP PR should be reviewed as soon as possible label Jul 25, 2023
@kc284 kc284 force-pushed the feature/cdn-updates branch 4 times, most recently from accc3c9 to d71bb07 Compare July 27, 2023 12:10
danilo-delbusso
danilo-delbusso requested changes Jul 27, 2023
View reviewed changes
Copy link
Member

@danilo-delbusso danilo-delbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

found only one small thing that needs changing

XenAdmin/Dialogs/ServerUpdates/ConfigLcmUdpatesPage.cs Outdated Show resolved Hide resolved
XenModel/Actions/Updates/RepositoryProxyAction.cs Outdated Show resolved Hide resolved
XenAdmin/Dialogs/ServerUpdates/ConfigCdnUpdatesPage.cs Outdated Show resolved Hide resolved
@danilo-delbusso danilo-delbusso added the needs updating A reviewer has requested changes label Jul 27, 2023
@CitrixChris CitrixChris added the 1 approval PR has been approved by one reviewer label Jul 27, 2023
danilo-delbusso
danilo-delbusso approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@danilo-delbusso danilo-delbusso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danilo-delbusso danilo-delbusso added 2 approvals PR has been approved by two reviewers and removed 1 approval PR has been approved by one reviewer needs updating A reviewer has requested changes labels Jul 28, 2023
@kc284 kc284 merged commit 9473452 into xenserver:feature/cdn-updates Jul 28, 2023
1 check passed
@kc284 kc284 deleted the feature/cdn-updates branch July 28, 2023 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CitrixChris CitrixChris CitrixChris approved these changes

@danilo-delbusso danilo-delbusso danilo-delbusso approved these changes

Assignees

@kc284 kc284

Labels
2 approvals PR has been approved by two reviewers ASAP PR should be reviewed as soon as possible
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kc284 @danilo-delbusso @CitrixChris