Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Monzo tweaks / Bespoke fraction implementation #8

Merged
merged 4 commits into from
Nov 30, 2023
Merged

Monzo tweaks / Bespoke fraction implementation #8

merged 4 commits into from
Nov 30, 2023

Conversation

frostburn
Copy link
Member

No description provided.

@frostburn
Update dependencies
ef629b4
@frostburn
Tweak residual handling for zero
a7fb2e7 
Add the option to return the prime limit as an ordinal
@frostburn frostburn force-pushed the monzo-tweaks branch 3 times, most recently from 502eb9d to ef29fa5 Compare November 29, 2023 04:17
@frostburn
Copy link
Member Author

Requires some tweaks to moment-of-symmetry but the tests pass if this is used as the dependency.

@frostburn
Copy link
Member Author

Same goes for temperaments.

@frostburn
Copy link
Member Author

scaleworkshop-core also works with this. Could use some documentation though.

@frostburn
Copy link
Member Author

Nothing further discovered during self-review. Will likely merge tomorrow.

@frostburn
Copy link
Member Author

I think we should go all in if we're going to update dependencies.

@frostburn frostburn merged commit 1226ae1 into main Nov 30, 2023
1 check passed
@frostburn frostburn deleted the monzo-tweaks branch November 30, 2023 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@frostburn