Implement a faster fraction to monzo + residual converter #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arseniiv
approved these changes
Apr 19, 2024
| // Factors of two using bit magic | ||
| const twos = (n ^ (n - 1n)) & n; | ||
| n /= twos; | ||
| result[0] += Math.log2(Number(twos)); |
There was a problem hiding this comment.
I guess this is fast but right near bit magic it feels weird. Though of course bit magic is here just to count zeros at least semi-efficiently and not to be blazing fast, so there’s no contradiction anywhere in the end.
There was a problem hiding this comment.
This makes me uneasy as well. I'll add an apology in a comment.
There was a problem hiding this comment.
Actually breaks with 2n ** 1024n. 😅
Use a precalculated table for 7-limit conversion.
frostburn
force-pushed
the
gotta-go-fast
branch
from
dd9414f to
2d1928f
Compare
|
Doesn't break tests over at |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a precalculated table for 7-limit conversion.