-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement HashMap similar to Python's dict #19
Draft
frostburn
wants to merge
1
commit into
main
Choose a base branch
from
hash-map
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -54,5 +54,8 @@ | |
}, | ||
"engines": { | ||
"node": ">=10.6.0" | ||
}, | ||
"dependencies": { | ||
"ts-essentials": "^9.4.2" | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import {Primitive} from 'ts-essentials'; | ||
import {HashMap, Hashable} from '../hashable'; | ||
import {PRIMES} from '../primes'; | ||
import {Monzo, monzosEqual} from '../monzo'; | ||
import {describe, it, expect} from 'vitest'; | ||
|
||
/** | ||
* Partial implementation of a rational number capable of holding very large values with a limited number of prime factors. | ||
*/ | ||
class ImmutableMonzo extends Hashable { | ||
vector: Readonly<Monzo>; | ||
|
||
constructor(vector: Readonly<Monzo>) { | ||
super(); | ||
this.vector = vector; | ||
} | ||
|
||
valueOf(): number { | ||
let value = 1; | ||
for (let i = 0; i < this.vector.length; ++i) { | ||
value *= PRIMES[i] ** this.vector[i]; | ||
} | ||
return value; | ||
} | ||
|
||
strictEquals(other: Hashable | Primitive): boolean { | ||
if (other instanceof ImmutableMonzo) { | ||
return monzosEqual(this.vector, other.vector); | ||
} | ||
return false; | ||
} | ||
} | ||
|
||
function M(vector: Readonly<Monzo>) { | ||
return Object.freeze(new ImmutableMonzo(Object.freeze(vector))); | ||
} | ||
|
||
describe('Hash-map / dictionary', () => { | ||
it('can set / get keys that hash to the same value', () => { | ||
const thirty = M([1, 1, 1]); | ||
const big = M([100000]); | ||
const alsoBig = M([-1, 1000]); | ||
expect(thirty.valueOf()).toBe(30); | ||
expect(big.valueOf()).toBe(alsoBig.valueOf()); | ||
|
||
const map = new HashMap<number | ImmutableMonzo, string>([ | ||
[30, 'number'], | ||
[thirty, 'thirty'], | ||
[big, 'biig'], // Oops typo. To be overriden. | ||
]); | ||
|
||
map.set(alsoBig, 'also big'); | ||
map.set(M([100000]), 'big'); | ||
|
||
expect(map.get(30)).toBe('number'); | ||
expect(map.get(M([1, 1, 1]))).toBe('thirty'); | ||
expect(map.get(M([100000]))).toBe('big'); | ||
expect(map.get(M([-1, 1000]))).toBe('also big'); | ||
|
||
expect(map.size).toBe(4); | ||
}); | ||
|
||
it('can be cleared', () => { | ||
const map = new HashMap(); | ||
map.set(3, 4); | ||
expect(map.size).toBe(1); | ||
map.clear(); | ||
expect(map.size).toBe(0); | ||
expect(map.get(3)).toBe(undefined); | ||
}); | ||
|
||
// TODO: Rest of the methods of HashMap | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A good idea would be adding tests to cover every method of
HashMap
(but probably not necessaryHashSet
) because there are usually two main paths forHashable
and primitive types, so it’s good to at least be confident they don’t diverge in behavior.