Implement constant structure checkers #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostburn
force-pushed
the
constant-structure
branch
from
db85648 to
d80bd3c
Compare
frostburn
commented
Apr 5, 2024
src/index.ts
Outdated
| * @param steps Musical intervals measured in steps not including the implicit 0 at the start, but including the interval of repetition at the end. | ||
| * @returns `true` if the scale has constant structure `false` otherwise. | ||
| */ | ||
| export function hasConstantStructure(steps: number[]) { |
There was a problem hiding this comment.
This would be more useful if it returned the counter-example instead.
frostburn
force-pushed
the
constant-structure
branch
from
d80bd3c to
1bf22f0
Compare
|
Preliminary benchmarks indicate that pre-checking for CS in 5407372813edo is around 8 times faster than the exact search. |
One for equal temperaments producing a counter-example and one with a margin of equivalence.
frostburn
force-pushed
the
constant-structure
branch
from
1bf22f0 to
5b292b5
Compare
|
Fixed a corner case and made both variants accept the empty scale. (The first one couldn't reject it even if it wanted to.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One for equal temperaments and one with a margin of equivalence.