Skip to content

Commit

Permalink
Update xen-dev-utils dependency
Browse files Browse the repository at this point in the history
Make sure the frostburn temperament is calculated correctly

ref xenharmonic-devs/scale-workshop#518
  • Loading branch information
frostburn committed Dec 28, 2023
1 parent cb155da commit 68601ef
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 5 deletions.
8 changes: 4 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,6 @@
"dependencies": {
"mathjs": "^12.1.0",
"ts-geometric-algebra": "^0.5.0",
"xen-dev-utils": "^0.2.0"
"xen-dev-utils": "^0.2.2"
}
}
11 changes: 11 additions & 0 deletions src/__tests__/temperament.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -243,6 +243,17 @@ describe('Temperament', () => {
expect(dot(arcturus, majorSixth)).toBeCloseTo(878.042);
});

it('calculates frostburn in the 2.5.7 subgroup', () => {
const monzo = [-5, 0, 7, -4, 0, 0, 0];
const subgroup = new Subgroup('2.5.7');
const temperament = Temperament.fromCommas([monzo], subgroup, true);
const [period, generator] = temperament.periodGenerator({
temperEquaves: true,
});
expect(period).toBeCloseTo(1200.3479);
expect(generator).toBeCloseTo(204.3389);
});

it('calculates starling rank 3 from a comma', () => {
const comma = toMonzo(new Fraction(126, 125));
const temperament = Temperament.fromCommas([comma]);
Expand Down

0 comments on commit 68601ef

Please sign in to comment.