Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace C-style comments with nestable OCaml-style comments #332

Merged
merged 1 commit into from
Jun 2, 2024

Conversation

frostburn
Copy link
Member

ref #330

@frostburn frostburn requested a review from inthar-raven May 24, 2024 07:18
@frostburn
Copy link
Member Author

@osmiumic You might want to take a look as well.

@frostburn frostburn linked an issue May 24, 2024 that may be closed by this pull request
@osmiumic
Copy link
Contributor

i dont understand github very well so i dont know how bad (or not) their search functionality is, but after this is merged i'd recommend looking for all instances of // to see if there's any single-line comments that havent been converted

also relevant: an idea i suggested before: warn users who use 2 or more /s that these are not comments but rather lifts (which could could also serve as a way of catching anything missed potentially, assuming that all SonicWeave code in the repo/in general is compiled at some stage)

@frostburn frostburn merged commit 7ed2ba4 into main Jun 2, 2024
1 check passed
@frostburn frostburn deleted the nested-comments branch June 2, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inline comments clash with double-lift
2 participants