Make virtual keyboard text color dynamic based on background #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use white text with dark backgrounds and black text with light background. ref #661
|
@wilckerson Would you mind reviewing this solution to virtual keyboard contrast issues? |
wilckerson
approved these changes
Apr 19, 2024
|
Since this PR is related to UI changes, do you have any screenshots of how it is looking? |
|
|
Judging as accepted based on the heart emoji and lack of explicit rejection. |
|
Yeah, It looks awesome. Sorry, for not being more clear with my message. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use white text with dark backgrounds and black text with light background.
ref #661