made multichannel-to-equave settings and color mapping dependent on mode #657
Conversation
|
If you're hiding the color mapping stuff there should be a corresponding bypass in App.vue to make sure multichannel mode doesn't behave strangely. |
| v-model="midi.multichannelEquavesDown" | ||
| /> | ||
| </template> | ||
| <template v-if="!midi.multichannelToEquave"> |
There was a problem hiding this comment.
This could be a v-else but then the template becomes more rigid. Maybe two separate v-ifs is better. Just wanted to point out the syntax.
There was a problem hiding this comment.
thanks, I noticed that possibility this morning while looking around other places where v-if pops up
|
2nd commit adds changes to App.vue and Midi Piano so chromatic mode behaviour reverts when in multichannel-to-equave mode |
|
Missing bypass near |
|
fixed... |
| @@ -156,7 +158,7 @@ function midiNoteOn(index: number, rawAttack?: number, channel?: number) { | |||
| if (!midi.velocityOn) { | |||
| rawRelease = 80 | |||
| } | |||
| if (whiteMode === 'simple') { | |||
| if (whiteMode === 'simple' || multichannel) { | |||
There was a problem hiding this comment.
I guess this is on me for writing bad code in the first place. Enough churn. I'll fix it on main.
made options visible depending on multichannel-to-equave checkbox