Remove dropdown for Pythagorean enharmonic #641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frostburn
commented
Apr 8, 2024
src/stores/scale.ts
Outdated
| @@ -287,6 +287,12 @@ export const useScaleStore = defineStore('scale', () => { | |||
| latticeView.__doc__ = 'Store the current scale to be displayed in the lattice tab.' | |||
| latticeView.__node__ = builtinNode(latticeView) | |||
|
|
|||
| function warn(message: string) { | |||
There was a problem hiding this comment.
This should take multiple arguments and conform to the new warn() in sonic-weave.
Use the sharp enharmonic by default (MIDI standard). Motivate the user to declare an explicit root pitch when using a black base note. Update sonic-weave dependency. Hook into the warning system. SonicWeave changelog: - Binary prefixes - "Aug" and "dim" as alternatives for "a" and "d" - Vulgar fractions of Aug, M, #, etc. in Pythagorean notation - Make "/" a bona fide operator - Helpful warning to let the user know that fraction reduction is called "simplify" ref #640
frostburn
force-pushed
the
remove-enharmonics
branch
from
cb7a053 to
9d58842
Compare
|
Does what was agreed to in the issue. Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the sharp enharmonic by default (MIDI standard). Motivate the user to declare an explicit root pitch when using a black base note.
ref #640