Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonic-weave dependency #629

Merged
merged 1 commit into from
Mar 29, 2024
Merged

Update sonic-weave dependency #629

merged 1 commit into from
Mar 29, 2024

Conversation

frostburn
Copy link
Member

Adds stepString() which labels the last interval in the scale with the step pattern.
Fix parsing if negative integers.
Make function parameters required by default.
Add array access with arrays of indices and of booleans.

Adds stepString() which labels the last interval in the scale with the step pattern.
Fix parsing if negative integers.
Make function parameters required by default.
Add array access with arrays of indices and of booleans.
@frostburn frostburn requested a review from inthar-raven March 29, 2024 01:08
Copy link
Contributor

@inthar-raven inthar-raven left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit would just update main to beta 3, right?

@frostburn
Copy link
Member Author

This commit would just update main to beta 3, right?

Correct.

@inthar-raven
Copy link
Contributor

Does the array access with indices work like map array indices (in pseudo-Haskell, viewing the array as a function)? And the Boolean thing is the array applied to the true indices, right?

@frostburn
Copy link
Member Author

Does the array access with indices work like map array indices (in pseudo-Haskell, viewing the array as a function)? And the Boolean thing is the array applied to the true indices, right?

It's been a while since I've programmed in Haskell. I think what you're saying is true. The model I'm trying to emulate is numpy for Python.

@frostburn frostburn merged commit 7cb1e15 into main Mar 29, 2024
2 checks passed
@frostburn frostburn deleted the step-string branch March 29, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants