Make the key index number viewable #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi Max! We're in the middle of a beta cycle here. See the The issue you raised would be #286 we just haven't gotten around to it yet. |
|
I was able to run main branch the app locally actually without a problem and this change did do what I was looking for. It felt pretty harmless / non-intrusive, so I opened the PR as I thought someone else might find it useful, but feel free to close if you don't think it's relevant |
|
Seems harmless enough. I'll review today at some point. |
frostburn
approved these changes
Mar 29, 2024
|
Now live at: https://sw3.lumipakkanen.com/?version=3.0.0-beta.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time working with Vue here, so this is maybe not the best way to do this.
My problem is using the, virtual keyboard I'm confused which notes the keys are mapping to. I'm a new user of scale-workshop (just found it last weekend) and have been exploring different tonal system using the "load default" functionality.
Eventually (at least in my opinion) it would probably be helpful to have a setting that would overlay the key number and/of frequency over the keys to make it more clear for non-developers that wouldn't know how to find this info via DevTools.
For now I was just adding this because I find it useful at least. I can pop-open DevTools and double-check which key number for each key in the keyboard, and then cross reference that back to the build scale tab.