Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MOS indicators on Circle tab of Rank 2 Temperament #589

Merged
merged 1 commit into from
Mar 2, 2024
Merged

Add MOS indicators on Circle tab of Rank 2 Temperament #589

merged 1 commit into from
Mar 2, 2024

Conversation

frostburn
Copy link
Member

ref #580

@frostburn frostburn requested a review from akselai February 29, 2024 18:14
frostburn
frostburn commented Feb 29, 2024
View reviewed changes
package.json Outdated Show resolved Hide resolved
@frostburn
Copy link
Member Author

Scott Dakota — Yesterday at 10:21 PM

Accessibility note:
Some humans, particularly males, are blue-green color blind, to varying degrees, and have a very hard time telling apart shades of green, blue, blue-green.

It's good practice to look up accessibility-safe color pallettes for data visualization. This has been worked out in the commercial world.

And that MOS range visualizer looks great!

@frostburn
Copy link
Member Author

image
(2 period screenshot for reference)
Improved the contrast of the greens based on an online checker. The rest of the suggestions were for the pre-existing theme. Will defer further accessibility issues to version 3.

@frostburn
Copy link
Member Author

image
Light mode for reference.

@frostburn frostburn linked an issue Mar 2, 2024 that may be closed by this pull request
Add MOS indicators on Circle tab of Rank 2 Temperament #580
Closed
@frostburn
Copy link
Member Author

Reviewed on Discord: "tbh its not too bad"

@frostburn frostburn merged commit 067d866 into main Mar 2, 2024
1 check passed
@frostburn frostburn deleted the mos-indicators branch March 2, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akselai akselai Awaiting requested review from akselai

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add MOS indicators on Circle tab of Rank 2 Temperament
1 participant
@frostburn