Use pinia to manage app state #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is still very much broken. Just opening a PR so that I can write down notes. |
|
Probably OK now. Automated tests including e2e pass. Will do more manual testing later. |
frostburn
commented
Jan 5, 2024
|
Some of the MIDI stuff couples too tightly with everything and resists clean separation. |
frostburn
commented
Jan 6, 2024
frostburn
force-pushed
the
more-pizza
branch
5 times, most recently
from
f969dc2 to
8f8596a
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Fix a bug where deactivated channel messages were passed to MIDI out from MIDI in. ref #367
|
Looked through the changes, did more testing and fixed couple of bugs I found. We need pinia to address #529 so I'm merging this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #367