MTS "Bulk Tuning Dump" exporter & Korg exporter refactoring #447
Conversation
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
from
ed49c41 to
6e0037d
Compare
| type="text" | ||
| id="name" | ||
| v-model="name" | ||
| maxlength="16" |
There was a problem hiding this comment.
Are you sure this is enough validation? I'm unable to break it myself, but you could enforce clampName everytime the ref is updated.
There was a problem hiding this comment.
That must have been an oversight after I realized how to do it for presetIndex. I'm used to using computed properties in Vue2 for this kinda stuff, so I was toying around with it before I figured it out.
|
The sister PR xenharmonic-devs/xen-dev-utils#7 needs to be resolved and published before this PR can be merged. |
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
2 times, most recently
from
e580dfd to
9b37db1
Compare
| // const deviceId = ref(0); | ||
| // const bank = ref(0); (only for message 0x0804) | ||
|
|
||
| const name = ref(clampName(props.scaleName)); |
There was a problem hiding this comment.
This update should hapen every time the modal is opened. Now this line of code basically reads like a statement of intent that masquerades as a computed property.
There was a problem hiding this comment.
I was able to add a watcher on props to solve this, but I'm not sure if this is the best way to implement input formatting. Do you think there's a better way?
I tried an approach with a writable computed property (something I normally do in BootstrapVue) but couldn't get it to work, plus the Vue3 documentation says that should only be used in rare cases anyway.
There was a problem hiding this comment.
Yeah, it's a weird case because you want changes in the scale name to affect the clamped name but not the other way around. I'll check if there's a straightforward solution.
There was a problem hiding this comment.
This does what I'm after: Updating the name on the main interface changes what's in the modal, but modifying the modal text input doesn't reflect back on the main interface.
const name = ref("");
watch(
() => props.scaleName,
(newValue) => {
name.value = clampName(newValue);
},
{ immediate: true }
);There was a problem hiding this comment.
You could attach a watcher to the name ref to do the input formatting, but the currently implemented @input should work too.
@input is already used in the project elsewhere, but for consistency you could refactor the logic into a method so that there's no assignment code inside the template.
There was a problem hiding this comment.
Thanks so much! That's close to what I came up with too, good to have some validation on that.
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
from
9b37db1 to
96f6136
Compare
|
The one thing I noticed that I'd rather pass on fully solving for this particular PR is improving the circle consistency of the info-question CSS definition. I noticed on a different computer it doesn't render a perfect circle, I'm guessing because of OS font differences. |
That's perfectly OK. Simply create a new issue about circle consistency and reference this PR so that we can fix it later. |
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
2 times, most recently
from
1cc89e7 to
44ba665
Compare
|
The 'OK' button must be fixed. As of now clicking it does nothing. Other than that, great work! I won't test the actual files generated as I don't have the hardware. We have two production deployments so Korg owners can do the testing for us. |
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
from
44ba665 to
014dd8f
Compare
| <template #footer> | ||
| <div class="btn-group"> | ||
| <button | ||
| @click="$emit('confirm')" |
vsicurella
force-pushed
the
mts-korg-exporters-squashed
branch
from
014dd8f to
af1cb63
Compare
|
Seems gnome 🧝 free now. Merging. |
This adds a .syx exporter that adheres to the MIDI Tuning specification of the "Bulk Tuning Dump" SysEx message, and also refactors the Korg exporter to be able to export in different formats associated with different supported synth models.
The Korg exporter now relies on some of the same code as the MTS Exporter since it's really just a wrapper around the same data.
Note: The previous Korg exporter implementation had some math errors affecting the least-signficant byte of the tuning data for each note. I'm not sure the extent of the error (it's a tricky calculation) but I would expect noticeable differences and would encourage users to re-export and re-import their scales.